RFR(S): 8213914: [TESTBUG] Several JFR VM events are not covered by tests

[Mikhailo Seledtsov]

Hi Markus,

   I wondered this myself. But only one event actually used the wrong 
name (EvacuationInfo), and the test passed. Here is a detailed breakdown 
on the change:

This change contains fixes that can be divided into 3 categories:
   - the events that were not listed in test/lib/.../EventNames.java, 
hence were not tested at all: " GCPhasePauseLevel4", " GCPhaseConcurrent"
   - events were spelled correctly, but their references/aliases used 
shorter names:
     EventNames. CompilerConfig --> EventNames.CompilerConfiguration,
     EventNames.SafepointStateSyncronization --> 
EventNames.SafepointStateSynchronization  (syncr --> synchr)
     This part of the change is to satisfy my verification scripts that 
reads event names from metadata.xml, and then verifies that the names 
are used/mentioned in the jfr tests.
   - only one case where the wrong event name was used, and the test 
actually passed: EvacuationInfo --> EvacuationInformation
      Not sure why test passed before. I can do a quick check now how 
this happened, and possibly file an RFE if this leads to a longer 
investigation.

Thank you,
Misha

On 11/15/18, 1:35 AM, Markus Gronlund wrote:
> Hi Misha,
>
> Thanks for looking into this.
>
> What exactly are the situation being addressed here?
> Have we been running tests with the wrong Event names in addition to the tests not being able to detect this? That is, the tests have been run, reported successful, but not really testing anything?
>
> Markus
>
> -----Original Message-----
> From: Mikhailo Seledtsov
> Sent: den 15 november 2018 05:02
> To: hotspot-jfr-dev at openjdk.java.net; Erik Gahlin<erik.gahlin at oracle.com>; Markus Gronlund<markus.gronlund at oracle.com>
> Subject: RFR(S): 8213914: [TESTBUG] Several JFR VM events are not covered by tests
>
> Please review this fairly small change that enables/adds testing for several JVM JFR events that were not covered.
>       JBS: https://bugs.openjdk.java.net/browse/JDK-8213914
>       Webrev: http://cr.openjdk.java.net/~mseledtsov/8213914.00/index.html
>       Testing:
>           Ran open/test/jdk/jdk/jfr/ on multiple platforms
>           All PASS
>
>
> Thank you,
> Misha
>