PING: RFR: 8213015: Inconsistent settings between JFR.configure and -XX:FlightRecorderOptions

[Markus Gronlund]

Looks OK but this will cause tests to fail. 

Please ensure you pass all tests in test/jdk/jdk/jfr.

Thanks
Markus

-----Original Message-----
From: Yasumasa Suenaga <yasuenag at gmail.com> 
Sent: den 19 november 2018 14:32
To: hotspot-jfr-dev at openjdk.java.net
Subject: PING: RFR: 8213015: Inconsistent settings between JFR.configure and -XX:FlightRecorderOptions

PING: Could you review it?

>       JBS: https://bugs.openjdk.java.net/browse/JDK-8213015
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8213015/webrev.00/


Yasumasa


On 2018/11/01 22:58, Yasumasa Suenaga wrote:
> Hi all,
> 
>       JBS: https://bugs.openjdk.java.net/browse/JDK-8213015
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8213015/webrev.00/
> 
> globalbuffersize, thread_buffer_size, memorysize, maxchunksize in -XX:FlightRecorderOptions can be set as "MEMORY SIZE" type. OTOH them in JFR.configure cannot be set so because they are defined as JLONG.
> 
> Also default values between JFR.configure and -XX:FlightRecorderOptions are inconsistent - globalbuffercount and memorysize. They should be consistent.
> 
> 
> Could you review it?
> 
> 
> Thanks,
> 
> Yasumasa (ysuenaga)