Emergency JFR dump at OOME

[Yasumasa Suenaga]

Hi all,

According to [1], I guess JFR dumps flight record to file.
But current JFR don't do so.

Should we fix it as below?
--------------------
diff -r 003c062e16ea src/hotspot/share/utilities/debug.cpp
--- a/src/hotspot/share/utilities/debug.cpp     Wed Oct 24 21:17:30 2018 -0700
+++ b/src/hotspot/share/utilities/debug.cpp     Thu Oct 25 19:56:54 2018 +0900
@@ -58,6 +58,9 @@
  #include "utilities/globalDefinitions.hpp"
  #include "utilities/macros.hpp"
  #include "utilities/vmError.hpp"
+#if INCLUDE_JFR
+#include "jfr/jfr.hpp"
+#endif

  #include <stdio.h>

@@ -321,6 +324,8 @@
        fatal("OutOfMemory encountered: %s", message);
      }

+    JFR_ONLY(Jfr::on_vm_shutdown(false);)
+
      if (ExitOnOutOfMemoryError) {
        tty->print_cr("Terminating due to java.lang.OutOfMemoryError: %s", message);
        os::exit(3);
--------------------

I will file it to JBS and will send review request if it is verified.


Thanks,

Yasumasa


[1] https://hg.openjdk.java.net/jdk/jdk/file/003c062e16ea/src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp#l159