RFR(S): 8235454: [TESTBUG] Basic test for JFR event streaming for jdk_jfr_sanity

Erik Gahlin erik.gahlin at oracle.com
Tue Dec 10 04:41:57 UTC 2019


Looks good 

When it comes to failure mode.

I think it is better to let the test harness determine what is a reasonable timeout, and if needed, it can be change from the outside for all tests. Also, if the test fails using a timeout, the test harness will (hopefully) take a thread dump, which is useful for troubleshooting.

Erik

> On 10 Dec 2019, at 02:36, mikhailo.seledtsov at oracle.com wrote:
> 
> Please review this change that introduces a very simple basic/sanity test for JFR streaming, and adds this test to jdk_jfr_sanity (which runs in tier-1).
> 
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8235454
>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8235454.00/
>     Testing:
>         1. Ran this test over 200 times on multiple platforms in the test cluster: ALL PASS
> 
>          2. Ran the group jdk_jfr_sanity 80 times: ALL PASS
> 
> Thank you,
> Misha
> 



More information about the hotspot-jfr-dev mailing list