Re: [RFR] 8235857: Add the parameter cushion length to WriterHost::ensure_size

Denghui Dong denghui.ddh at alibaba-inc.com
Tue Dec 31 02:31:11 UTC 2019


Ping. :)
Could you review it?

Denghui Dong
------------------------------------------------------------------
From:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>
Send Time:2019年12月13日(星期五) 10:27
To:hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
Subject:[RFR] 8235857: Add the parameter cushion length to WriterHost::ensure_size

Hi team:

Please help review the following changeset:

Bug: https://bugs.openjdk.java.net/browse/JDK-8235857
Webrev: http://cr.openjdk.java.net/~ddong/8235857/webrev.00/

Summary:
There is a path to call WriterHost::write(const T* value, size_t len) in WriterHost::write(jstring string),
it's necessary to pass the length of jchar so that WriterHost::ensure_size can know the length of cushion.
For the java event side, the max length of the cushion has already been counted in the method "jdk.jfr.internal.EventWriter#putStringValue".

Thanks,
Denghui Dong



More information about the hotspot-jfr-dev mailing list