PING: RFR: 8217362: Emergency dump does not work when disk=false is set

[Markus Gronlund]

Hi again Yasumasa,

Thanks for the feedback, I have updated and incorporated your suggestion on JVM_MAXPATHLEN.

Rebased webrev:
http://cr.openjdk.java.net/~mgronlun/8217362/webrev03/ 

I have also taken ownership of the bug and will put you down as a contributor on this changeset - that ok?

Thanks
Markus

-----Original Message-----
From: Yasumasa Suenaga <yasuenag at gmail.com> 
Sent: den 15 februari 2019 02:52
To: Markus Gronlund <markus.gronlund at oracle.com>
Cc: hotspot-jfr-dev at openjdk.java.net
Subject: Re: PING: RFR: 8217362: Emergency dump does not work when disk=false is set

Hi Markus,

I have two comments for your change.

  - jfrEmergencyDump.cpp: L262:
      You use O_BUFLEN for dump path. It might be not enough for it.
      Can you use JVM_MAXPATHLEN?

  - I could not apply your change straightly to current HEAD of jdk/jdk.
    It seems to be caused by the change of 8218935.
    Can you update your change?

In addition, may I change assignee of 8217362 to you?


Thanks,

Yasumasa

2019年2月15日(金) 2:04 Markus Gronlund <markus.gronlund at oracle.com>:
>
> Hi again Yasumasa,
>
> Thank you for finding and reporting this. Looks like I managed to introduce this bug in the attempt to modularize for the open source effort.
>
> Your patch reminded me of another patch I had been working on with the intent to move the remaining emergency dump logic from jfrRepository into jfrEmergencyDump proper.
>
> I suggest we take the opportunity to fix this in a unified way under this bug (retaining the modified test to test for the in memory emergency case - thanks).
>
> Here is a suggestion:
>
> http://cr.openjdk.java.net/~mgronlun/8217362/webrev02/
>
> Thanks
> Markus
>
> -----Original Message-----
> From: Markus Gronlund
> Sent: den 14 februari 2019 11:33
> To: Yasumasa Suenaga <yasuenag at gmail.com>
> Cc: hotspot-jfr-dev at openjdk.java.net
> Subject: RE: PING: RFR: 8217362: Emergency dump does not work when 
> disk=false is set
>
> Hi Yasumasa,
>
> Sorry for the delay on this, I will take a look and get back to you.
>
> Thanks
> Markus
>
> -----Original Message-----
> From: Yasumasa Suenaga <yasuenag at gmail.com>
> Sent: den 13 februari 2019 15:41
> To: hotspot-jfr-dev at openjdk.java.net
> Subject: PING: RFR: 8217362: Emergency dump does not work when 
> disk=false is set
>
> PING: Could you review?
>
> >>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217362
> >>    webrev:
> >> http://cr.openjdk.java.net/~ysuenaga/JDK-8217362/webrev.00/
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2019/02/02 14:01, Yasumasa Suenaga wrote:
> > PING: Could you review it?
> >
> >>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217362
> >>    webrev:
> >> http://cr.openjdk.java.net/~ysuenaga/JDK-8217362/webrev.00/
> >
> >
> > Thanks,
> >
> > Yasumasa
> >
> >
> > On 2019/01/18 16:25, Yasumasa Suenaga wrote:
> >> Hi all,
> >>
> >> Please review this change:
> >>
> >>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217362
> >>    webrev:
> >> http://cr.openjdk.java.net/~ysuenaga/JDK-8217362/webrev.00/
> >>
> >> We cannot get emergency dump of flight record if disk=false is 
> >> passed to HotSpot.
> >> This change works fine on all tests on submit repo and jdk_jfr jtreg tests.
> >>
> >>
> >> Thanks,
> >>
> >> Yasumasa
> >>