RFR: [JDK-8216565] Specifying the same path creates a new directory in JFR.configure

[Yasumasa Suenaga]

Hi Chihiro,

The condition in if-statement is a little verbosely.
I think it becomes more simple if you implement SafePath::equals and use it.


Thanks,

Yasumasa


On 2019/01/12 0:49, Chihiro Ito wrote:
> Hi all,
> 
> I reported a following behabior as a bug. [JDK-8216565]
> 
> Could I have a reviews for small patch, please ?
> 
> -- 
> Even if you specify the same path as repositorypath in JFR.configure, a new subdirectory is created every time.
> 
> $ ${JAVA_HOME}/bin/jcmd 17535 JFR.configure repositorypath=/tmp
> 17535:
> Repository path: /tmp/2019_01_12_00_28_53_17535
> 
> $ ${JAVA_HOME}/bin/jcmd 17535 JFR.configure repositorypath=/tmp
> 17535:
> Repository path: /tmp/2019_01_12_00_29_03_17535
> 
> If the same directory is specified, you should not create a new .
> -- 
> 
> Regards,
> Chihiro
> 
> 
> On 2019/01/10 1:12, Chihiro Ito wrote:
>> Hi all,
>>
>> Could I have a reviews for this fix of "jcmd JFR.configure", please ?
>> This patch passed all tests in test-tier1.
>>
>> http://cr.openjdk.java.net/~cito/webrev.00/
>>
>> In current implementation even if user specify the same repository base path in jcmd JFR.configure, hotspot create a new directory (base path + timestamp) as repository.
>>
>> This patch is hotspot don't create new directory and hotspot keep to use current one.
>>
>> Regards,
>> Chihiro
>>
>>
>>
>