RFR: 8216995: Clean up JFR command line processing

Claes Redestad claes.redestad at oracle.com
Tue Jan 15 10:29:34 UTC 2019


Thanks, Markus!

/Claes

On 2019-01-15 10:34, Markus Gronlund wrote:
> Hi Claes,
> 
> Looks good, thanks for fixing this.
> 
> Markus
> 
> -----Original Message-----
> From: Claes Redestad
> Sent: den 14 januari 2019 18:34
> To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>; hotspot-jfr-dev at openjdk.java.net
> Subject: RFR: 8216995: Clean up JFR command line processing
> 
> Hi,
> 
> JFR setup could be simplified by using macros defined in globals_extension.hpp rather than use JVMFlag directly.
> 
> On top of looking cleaner this avoids JVMFlag::find_flag, which does a linear scan of all flags. So a tiny startup optimization (detectable only with special goggles).
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8216995/open.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8216995
> 
> Testing: tier1-2 (ongoing)
> 
> Thanks!
> 
> /Claes
> 


More information about the hotspot-jfr-dev mailing list