RFR(S) : 8225554 : add JFR event for uncommon trap

[Igor Ignatev]

Misha,
thanks for your review. I’ll update the year before pushing, thanks for bringing this up to my attention. 

Compiler folks,
Can someone take a look?

Cheers,
— Igor

> On Jun 17, 2019, at 6:02 PM, mikhailo.seledtsov at oracle.com wrote:
> 
> Hi Igor,
> 
> Overall looks good from procedural POV of adding JFR event. The test looks good as well.
> 
> I am not familiar well enough with compiler domain, hence someone familiar with compiler should review this as well.
> 
> And, perhaps Markus would like to review as well (added him to CC).
> 
>  Minor: please update Copyright year prior to push in jfrType.cpp (no need to re-post webrev for this).
> 
> 
> Misha
> 
>> On 6/11/19 11:49 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8225554/webrev.00/index.html
>>> 187 lines changed: 184 ins; 0 del; 3 mod;
>> Hi all,
>> 
>> could you please review this small patch which adds jfr event for uncommon trap?
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8225554/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8225554
>> testing:
>>  - tier1 (which includes a newly added test)
>>  - modified version of compiler/intrinsics/klass/CastNullCheckDroppingsTest.java (see JDK-8129092[1])
>> 
>> [1] https://bugs.openjdk.java.net/browse/JDK-8129092
>> 
>> Thanks,
>> -- Igor