PING: RFR: 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero

[Yasumasa Suenaga]

PING: Could you review it?

>>>   JBS: https://bugs.openjdk.java.net/browse/JDK-8219566
>>>   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8219566/webrev.00/


If you have any questions, please tell me.


Thanks,

Yasumasa


On 2019/02/27 22:46, Yasumasa Suenaga wrote:
> Hi Erik,
> 
> On 2019/02/27 22:30, Erik Gahlin wrote:
>> Hi Yasumasa,
>>
>> Could you explain a little about the bug?
>>
>> Why should stack traces be collected if MaxJavaStackTraceDepth is set to 0.
> 
> "0" in MaxJavaStackTraceDepth means all exception stack traces
> will be shown.
> 
> http://hg.openjdk.java.net/jdk/jdk/file/72ce7dd54939/src/hotspot/share/runtime/globals.hpp#l1553
> 
> JDK-7179701 reports similar issue.
> I think we can take similar approach for JDK-8219566.
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
>> Thanks
>> Erik
>>
>>> On 22 Feb 2019, at 07:48, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>>>
>>> Hi all,
>>>
>>> Please review this change:
>>>
>>>   JBS: https://bugs.openjdk.java.net/browse/JDK-8219566
>>>   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8219566/webrev.00/
>>>
>>> JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero.
>>> This bug is similar to JDK-7179701.
>>>
>>> This change passed tests on submit repo and :jdk_jfr jtreg tests.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>