RFR: 8223498: Add Sum of Duration to the jfr summary command

Yasumasa Suenaga yasuenag at gmail.com
Wed May 8 13:03:20 UTC 2019


Hi Chihiro,


I think Statistics.sumOfDurationTicks might be overflown.
Many thread might be in park and/or sleep event. If so, sum value will 
be very large number.

IMHO we need to set Long.MAX_VALUE to sumOfDurationTicks if it exceeds 
Long.MAX_VALUE. Then sum value will be shown like "<= 999999999 ns".

If sum value exceeds LONG_MAX, sumOfDurationTicks is set to 
Long.MAX_VALUE, and it is shown console like "<= 9999999999 ns".

nanosec might be very large number. So we can use exponent to show.


Thanks,

Yasumasa


On 2019/05/08 2:53, Chihiro Ito wrote:
> Hi,
> 
> Could you review this enhancement, please?
> 
> This enhancement adds the total duration of each event to the jfr
> summary command to help the user determine which events to display in
> the jfr output.
> 
> webrev:
> http://cr.openjdk.java.net/~cito/JDK-8223498/webrev.00/
> <http://cr.openjdk.java.net/%7Ecito/JDK-8223498/webrev.00/>
> 
> jbs:
> https://bugs.openjdk.java.net/browse/JDK-8223498
> 
> I have passed the tests in test/jdk/jdk/jfr.
> 
> Best regards,
> Chihiro
> 


More information about the hotspot-jfr-dev mailing list