RFR(M): 8220293: Deadlock in JFR string pool
Robbin Ehn
robbin.ehn at oracle.com
Tue May 21 13:48:40 UTC 2019
Hi Markus,
On 2019-05-03 15:00, Markus Gronlund wrote:
> Greeting,
>
> Please review the following patch to address the following:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220293
> Webrev: http://cr.openjdk.java.net/~mgronlun/8220293/webrev01/
>
> High level summary:
>
> We don't want to release a retired buffer, because this will break the invariant that a successful acquisition implies a valid (non-retired) buffer.
> This is the reason why this work is, at least prima facie, a little more involved.
This seems fine, from my limited understanding of jfr buffer subsystem.
Thanks for fixing!
/Robbin
>
> Tests:
> test case / reproducer attached to: https://bugs.openjdk.java.net/browse/JDK-8220293
> open/test/jdk/:jdk_jfr
>
> Thank you
> Markus
>
More information about the hotspot-jfr-dev
mailing list