RFR(M): 8217089: JFR: Lazy install os interface components for improved startup

[Markus Gronlund]

Hi David,

Sorry for the delay in getting back to you on this, thank you for taking a look.

The existing callers are all located in jfrPeriodic.cpp and handles the OS_ERR return codes already (with logging).

Thanks again
Markus

-----Original Message-----
From: David Holmes 
Sent: den 10 maj 2019 04:32
To: Markus Gronlund <markus.gronlund at oracle.com>; Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>; hotspot-jfr-dev at openjdk.java.net
Subject: Re: RFR(M): 8217089: JFR: Lazy install os interface components for improved startup

Hi Markus,

On 5/05/2019 6:23 am, Markus Gronlund wrote:
> Greetings,
> 
> Please review the following patch to improve startup when using JFR:
> 
> Bug/Enh: https://bugs.openjdk.java.net/browse/JDK-8217089
> Webrev: http://cr.openjdk.java.net/~mgronlun/8217089/webrev01/
> 
> Summary:
> 
> Let the periodic event requestor thread lazy install os interface components instead of doing it eagerly as part of startup by the initial thread.

That all seems fine for single-threaded lazy initialization.

Only thing I'm unclear on is the addition of the potential to return OS_ERR. I can't see where these methods get called so can't tell if the callers are prepared to handle the error.

Thanks,
David
-----

> Thank you
> Markus
>