Re: RFR: 8234060: Potential memory reordering problem in JfrBuffer flush mechanism

[Denghui Dong]

Hi Markus,
  The webrev has been updated.
  And please help me to push it if there are no other problems, thanks!

Cheers,
Denghui Dong
------------------------------------------------------------------
From:Markus Gronlund <markus.gronlund at oracle.com>
Send Time:2019年11月13日(星期三) 19:16
To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>; hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
Subject:RE: RFR: 8234060: Potential memory reordering problem in JfrBuffer flush mechanism


Hi Denghui,
Looks good. You also remembered to update the Java side as well – very good.
Can you please move the #include “runtime/orderAccess.hpp” from jfrBuffer.cpp to jfrBuffer.hpp? No need for another webrev for that.
I can sponsor this change for you if needed.
Thanks again
Markus
From: Denghui Dong <denghui.ddh at alibaba-inc.com> 
Sent: den 13 november 2019 09:06
To: hotspot-jfr-dev at openjdk.java.net; markus.gronlund <markus.gronlund at oracle.com>
Subject: RFR: 8234060: Potential memory reordering problem in JfrBuffer flush mechanism
Hi,
Please help me to review this patch.
Bug: https://bugs.openjdk.java.net/browse/JDK-8234060
Webrev: http://cr.openjdk.java.net/~ddong/8234060/
Thanks,
Denghui Dong