PING: Re: RFR: 8219904: ClassCastException when calling FlightRecorderMXBean#getRecordings()

[Chihiro Ito]

Hi Erik,

Could you please review this?

Regards,
Chihiro

2019年10月25日(金) 0:43 Chihiro Ito <chiroito107 at gmail.com>:

> Hi Erik,
>
> I leave the isToDisk method to maintain compatibility so that I can
> connect to Java processes that this issue does not resolve.
> The isToDisk method was deprecated.
>
> Could you review this, please?
>
> JBS https://bugs.openjdk.java.net/browse/JDK-8219904
> webrev http://cr.openjdk.java.net/~cito/JDK-8219904/webrev.01/
>
> Regards,
> Chihiro
>
> 2019年10月24日(木) 1:12 Chihiro Ito <chiroito107 at gmail.com>:
>
>> Hi Erik,
>>
>> Thank you for prompt reply.
>>
>> I also checked the Javadoc. The key should be disk.
>>
>> > Is "toDisk" synthesized from the method name "isToDisk" in
>> > RecordingInfo, or is it set somewhere else?
>>
>> Yes, it appears to be composited from the isToDisk method.
>> For compatibility, I think you should leave the isToDisk method and add
>> @Deprecate, what do you think?
>>
>> This problem occurs when attaching over a network or to a process. The
>> process is connected over the network because it cannot be attached to its
>> own process.
>>
>> Regards,
>> Chihiro
>>
>> 2019年10月21日(月) 21:13 Erik Gahlin <erik.gahlin at oracle.com>:
>>
>>> Hi,
>>>
>>> The javadoc states that the key should be "disk" (which is the same used
>>> by jcmd and -XX:StartFlightRecording).
>>>
>>> Is "toDisk" synthesized from the method name "isToDisk" in
>>> RecordingInfo, or is it set somewhere else?
>>>
>>> Do the problem only occur if you access RecordingInfo over network? I am
>>> asking since you added a port to the test.
>>>
>>> Erik
>>> > Hi
>>> >
>>> > I fixed a problem with ClassCastException. Also, I fixed the
>>> CompositeData
>>> > field name because it was incorrect.
>>> >
>>> > Could you please review it?
>>> >
>>> > JBS https://bugs.openjdk.java.net/browse/JDK-8219904
>>> > Webrev http://cr.openjdk.java.net/~cito/JDK-8219904/webrev.00/
>>> >
>>> > The comment on the JBS mentions UneclaredThrowableException, which is a
>>> > different issue.
>>> >
>>> > Regards,
>>> > Chihiro
>>>
>>>