RFR: 8234671: JFR api/consumer/recordingstream/TestStart.java failed due to timeout at testStartTwice()

Markus Gronlund markus.gronlund at oracle.com
Thu Nov 28 21:41:44 UTC 2019


Looks good.

Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 28 november 2019 16:05
To: hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
Subject: RFR: 8234671: JFR api/consumer/recordingstream/TestStart.java failed due to timeout at testStartTwice()

Hi,

Could I have a review of a fix that makes sure that an updated configuration for an event stream, for example an added handler for onEvent, is always discovered by the thread processing the events. Today it may go unnoticed, if it is added after RecordingStream::start has been invoked, which is what happens in TestStart.java

The implementation also changes so a Dispatcher object is only created if a change to the configuration has actually occurred.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8234671

Webrev:
http://cr.openjdk.java.net/~egahlin/8234671/

Testing: jdk/jfr/* multiple times

Thanks
Erik




More information about the hotspot-jfr-dev mailing list