RFR(T): 8230865:[TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target

Igor Ignatyev igor.ignatyev at oracle.com
Fri Oct 11 01:29:03 UTC 2019


I'm a bit surprised that we still use a shell script to create a jar file given there are existing test libraries to do that, but the fix looks good to me.

-- Igor

> On Oct 10, 2019, at 4:56 PM, mikhailo.seledtsov at oracle.com wrote:
> 
> Please review this trivial change that fixes a build problem for this test:
> 
> diff --git a/test/jdk/jdk/jfr/event/io/EvilInstrument.java b/test/jdk/jdk/jfr/event/io/EvilInstrument.java
> --- a/test/jdk/jdk/jfr/event/io/EvilInstrument.java
> +++ b/test/jdk/jdk/jfr/event/io/EvilInstrument.java
> @@ -52,6 +52,7 @@
>   * @library /test/lib /test/jdk
>   * @modules java.instrument
>   *
> + * @build jdk.jfr.event.io.EvilInstrument
>   * @run shell MakeJAR.sh EvilInstrument 'Can-Redefine-Classes: true'
>   * @run main/othervm -javaagent:EvilInstrument.jar jdk.jfr.event.io.EvilInstrument
>   */
> 
> Thank you,
> 
> Misha
> 



More information about the hotspot-jfr-dev mailing list