RFR(XL): [JEP-349] 8226511: Implement JFR Event Streaming

[Markus Gronlund]

Hi Misha,

Thank you for the review.

EventProducer.java has already been fixed and I have just updated to correct the text in TestRepositoryProperty.java

Thanks again
Markus

-----Original Message-----
From: Mikhailo Seledtsov 
Sent: den 29 oktober 2019 23:49
To: Markus Gronlund <markus.gronlund at oracle.com>; hotspot-jfr-dev at openjdk.java.net
Subject: Re: RFR(XL): [JEP-349] 8226511: Implement JFR Event Streaming

I have reviewed the tests. Overall tests look good, with couple of minor
comments:

jfr/api/consumer/recordingstream/EventProducer.java
   Missing copyright header

jfr/api/consumer/streaming/TestRepositoryProperty.java
   93                 throw new AssertionError("Repository path should exist before JFR is initialized");
                              before --> after "Repository path should exist after JFR is initialized"

No need to update webrev for these corrections.


Misha

On 10/29/19 8:37 AM, Markus Gronlund wrote:
> Hi again,
>
> The webrev has been updated:
>
> http://cr.openjdk.java.net/~mgronlun/8226511/v1/webrev/
>
> Thank you
> Markus
>
> -----Original Message-----
> From: Markus Gronlund
> Sent: den 18 september 2019 21:48
> To: hotspot-jfr-dev at openjdk.java.net
> Subject: RFR(XL): [JEP-349] 8226511: Implement JFR Event Streaming
>
> Greetings,
>
> This is a RFR for JEP 349: JFR Event Streaming [1].
>
> The integration work is tracked under JBS issue 8226511 [2] with associated webrev [3], CSR [4] and JavaDocs [5].
>
> The code includes a demo example [6], provided for convenience to get a taste of what can be built on top of this feature*.
> The demo can be activated by starting a regular recording using a 
> specific name, "health", i.e. -XX:StartFlightRecording:name=health
>
> Thank you
> Markus and Erik
>
> [1] http://openjdk.java.net/jeps/349
> [2] https://bugs.openjdk.java.net/browse/JDK-8226511
> [3] http://cr.openjdk.java.net/~mgronlun/8226511/v0/webrev/webrev/
> [4] https://bugs.openjdk.java.net/browse/JDK-8226512
> [5] 
> http://cr.openjdk.java.net/~mgronlun/8226511/v0/docs/docs/api/jdk.jfr/
> jdk/jfr/consumer/package-summary.html
> [6] http://cr.openjdk.java.net/~egahlin/health-report-agent/health-report-example.txt
> *   The demo example code is only included for convenience, it will be removed later.
>