RFR(T): 8231323: ProblemList jdk/jfr/jcmd/TestJcmdConfigure.java

[Daniel D. Daugherty]

You are using the ProblemListing bug here.

You should be using the test failure bug instead.

Please resend your review request using:

     JDK-8231317 jdk/jfr/jcmd/TestJcmdConfigure.java fails with
                 "java.lang.RuntimeException: assertTrue: expected true, 
was false"
     https://bugs.openjdk.java.net/browse/JDK-8231317

Also, your review request should also include removing the test from the
ProblemList (as Yasumasa pointed out).

Dan


On 9/21/19 12:08 PM, Chihiro Ito wrote:
> Hi all,
>
> The file path in the test code was not supported on Windows.
> I have fixed it, so please review it.
>
> This fix passed on Windows and on Linux.
>
> JBS https://bugs.openjdk.java.net/browse/JDK-8231323
> webrev http://cr.openjdk.java.net/~cito/JDK-8231323/webrev.00/
>
> Regards,
> Chihiro
>
>
> 2019年9月21日(土) 23:13 Daniel D. Daugherty <daniel.daugherty at oracle.com 
> <mailto:daniel.daugherty at oracle.com>>:
>
>     Yasumasa,
>
>     Thanks for the fast review!
>
>     Dan
>
>
>     On 9/21/19 10:01 AM, Yasumasa Suenaga wrote:
>     > Hi Dan,
>     >
>     > Looks good to me.
>     >
>     > I believe Chihiro will work for this problem (JDK-8231317).
>     >
>     >
>     > Yasumasa
>     >
>     >
>     > On 2019/09/21 22:52, Daniel D. Daugherty wrote:
>     >> Greetings,
>     >>
>     >> Need to ProblemList a noisy test failure. Here's the bug:
>     >>
>     >>      JDK-8231323 ProblemList jdk/jfr/jcmd/TestJcmdConfigure.java
>     >> https://bugs.openjdk.java.net/browse/JDK-8231323
>     >>
>     >> and here's the diff:
>     >>
>     >> $ hg diff
>     >> diff -r e6231dbaa862 test/jdk/ProblemList.txt
>     >> --- a/test/jdk/ProblemList.txt    Sat Sep 21 08:06:00 2019 +0800
>     >> +++ b/test/jdk/ProblemList.txt    Sat Sep 21 09:45:46 2019 -0400
>     >> @@ -885,6 +885,7 @@
>     >>   jdk/jfr/event/io/EvilInstrument.java 8221331 generic-all
>     >>   jdk/jfr/event/runtime/TestNetworkUtilizationEvent.java
>     >> 8228990,8229370    generic-all
>     >>   jdk/jfr/event/compiler/TestCodeSweeper.java 8225209 generic-all
>     >> +jdk/jfr/jcmd/TestJcmdConfigure.java 8231317 windows-x64
>     >>
>     >>
>       ############################################################################
>
>     >>
>     >>
>     >>
>     >> We have a dozen sightings so far and all are on Win* machines.
>     >>
>     >> Thanks, in advance, for any comments, questions or suggestions.
>     >>
>     >> Dan
>