RFR: 8231317: jdk/jfr/jcmd/TestJcmdConfigure.java fails with "java.lang.RuntimeException: assertTrue: expected true, was false"

[Yasumasa Suenaga]

I will sponsor for you.

Yasumasa


On 2019/09/25 20:38, Chihiro Ito wrote:
> Hi Yasumasa and Dan,
> 
> Thank you for reviewing.
> 
> I upload the changeset. Cloud you push it, please?
> 
> http://cr.openjdk.java.net/~cito/JDK-8231317/JDK-8231317-changeset
> 
> Regards,
> Chihiro
> 
> 
> 2019年9月23日(月) 10:12 Daniel D. Daugherty <daniel.daugherty at oracle.com <mailto:daniel.daugherty at oracle.com>>:
> 
>     Single test failure in Tier5 and none in Tier6. The single test failure
>     was in sun/tools/jhsdb/JShellHeapDumpTest.java which is a known failure.
> 
>     There were a total of 8 executions of jdk/jfr/jcmd/TestJcmdConfigure.java
>     on Linux-X64, macOSX and Win-X64 and all passed.
> 
>     Dan
> 
> 
>     On 9/22/19 8:50 AM, Daniel D. Daugherty wrote:
>      > The fix looks good to me. I'm running it through Mach5 Tier[56] just
>      > to be sure.
>      >
>      > Dan
>      >
>      >
>      > On 9/21/19 11:58 PM, Yasumasa Suenaga wrote:
>      >> (CC'ed hotspot-runtime-dev and Dan)
>      >>
>      >> Hi Chihiro,
>      >>
>      >> Looks good.
>      >>
>      >>
>      >> Yasumasa
>      >>
>      >>
>      >> On 2019/09/22 12:45, Chihiro Ito wrote:
>      >>> Hi Erik and Yasumasa,
>      >>>
>      >>> Could you review this, please?
>      >>>
>      >>> Regards,
>      >>> Chihiro
>      >>>
>      >>> 2019年9月22日(日) 12:01 Chihiro Ito <chiroito107 at gmail.com <mailto:chiroito107 at gmail.com>
>      >>> <mailto:chiroito107 at gmail.com <mailto:chiroito107 at gmail.com>>>:
>      >>>
>      >>>     Hi all,
>      >>>
>      >>>     The file path in the test code was not supported on Windows.
>      >>>     I have fixed it, so please review it.
>      >>>
>      >>>     This fix passed on Windows and on Linux.
>      >>>
>      >>>     JBS https://bugs.openjdk.java.net/browse/JDK-8231317
>      >>>     webrev http://cr.openjdk.java.net/~cito/JDK-8231317/webrev.00/
>      >>>
>      >>>     Regards,
>      >>>     Chihiro
>      >>>
>      >
>      >
>