Re: RFR(XXS): 8242792: interval < flushInterval is always false in jdk.jfr.internal.RequestEngine#setFlushInterval

[Denghui Dong]

Hi Erik,

Found by inspection.

So flush-internal can not be set by users in the future?
------------------------------------------------------------------
From:Erik Gahlin <erik.gahlin at oracle.com>
Send Time:2020年4月15日(星期三) 16:08
To:hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
Subject:Re: RFR(XXS): 8242792: interval < flushInterval is always false in jdk.jfr.internal.RequestEngine#setFlushInterval

Looks good.

Did you find the issue by inspection, or was there a real issue?

Plan is to remove that code completely (after a release or two) as we 
don't think there is a practical need to set the flush interval above or 
below 1s.

Erik

On 2020-04-15 08:05, Denghui Dong wrote:
> Hi team,
>
> Could you please review this small patch?
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8242792
> webrev: http://cr.openjdk.java.net/~ddong/8242792/webrev.00/
>
> Summary:
> the condition interval < flushInterval is always false in jdk.jfr.internal.RequestEngine#setFlushInterval,
> and I also fix a typo in jdk/jfr/internal/JVM.java
>
> Thanks,
> Denghui Dong