RFR(XXS): 8242844: clean some error typos and log format

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Thu Apr 16 16:35:54 UTC 2020


I will sponsor your change,

Misha

On 4/15/20 8:10 PM, Denghui Dong wrote:
> Thanks for the review.
>
> Please help sponsor it :)
>
> Regards,
> Denghui Dong
>
>     ------------------------------------------------------------------
>     From:mikhailo.seledtsov <mikhailo.seledtsov at oracle.com>
>     Send Time:2020年4月16日(星期四) 01:28
>     To:Erik Gahlin <erik.gahlin at oracle.com>; 董登辉(卓昂)
>     <denghui.ddh at alibaba-inc.com>
>     Cc:hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
>     Subject:Re: RFR(XXS): 8242844: clean some error typos and log format
>
>     +1
>
>     On 4/15/20 9:39 AM, Erik Gahlin wrote:
>     > Looks good.
>     >
>     > Erik
>     >
>     >> On 15 Apr 2020, at 14:59, Denghui Dong <denghui.ddh at alibaba-inc.com> wrote:
>     >>
>     >> Hi team,
>     >>
>     >> Could you please review this small and trivial patch?
>     >> Just clean some typos and log format I found.
>     >>
>     >> For example:
>     >> in jdk.jfr.consumer.RecordedObject#getDuration(java.lang.String)
>     >>         throw newIllegalArgumentException(name, "java,time.Instant");
>     >>
>     >> "java,time.Duration" should be "java.time.Duration"
>     >>
>     >> JBS: https://bugs.openjdk.java.net/browse/JDK-8242844
>     >> webrev: http://cr.openjdk.java.net/~ddong/8242844/webrev.00/
>     >>
>     >> Thanks,
>     >> Denghui Dong
>


More information about the hotspot-jfr-dev mailing list