RFR (M) 8235573: Move JFR ObjectSample oop into OopStorage

[David Holmes]

Hi Coleen,

On 3/08/2020 11:14 pm, coleen.phillimore at oracle.com wrote:
<snip>
> 
> incremental webrev at 
> http://cr.openjdk.java.net/~coleenp/2020/8235573.02.incr/webrev
> full webrev at http://cr.openjdk.java.net/~coleenp/2020/8235573.03/webrev

src/hotspot/share/gc/shared/weakProcessorPhases.hpp

Have you built this with JVMTI disabled? I'm not sure if an empty enum 
declaration might produce a warning?

---

src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp

Are there any ordering constraints on these store pairs:

  68     Atomic::store(&_dead_samples, true);
  69     _last_sweep = JfrTicks::now();

  93   _last_sweep = JfrTicks::now();
  94   Atomic::store(&_dead_samples, false);

?

---

Otherwise this all seems good.

Thanks,
David
-----


> And retested.
> Thanks,
> Coleen
>