RFR: 8250913: EventHandlerCreator embeds an unnecessary StringPool
Chihiro Ito
chiroito107 at gmail.com
Thu Aug 6 13:34:09 UTC 2020
Hi,
Could you review this fix, please?
This fix passed submit-repo.
JBS : https://bugs.openjdk.java.net/browse/JDK-8250913
Webrev : http://cr.openjdk.java.net/~cito/JDK-8250913/webrev.00/
For each event class, EventHandlerCreator creates new classes that
extend EventHandler and are used by the event class of JFR.
These new classes have a write method to put event data to
thread-local buffers, and SpringPools if the corresponding event
classes have String fields.
The classes leverage EventWriter in its write method. In the write
method, for String data, the classes use the putString(String,
StringPool) method of EventWriter class.
The classes put their own SpringPool into this method as the second argument.
However, in this putString method the StringPool object that is the
second argument never is used. And the StringPool object never is used
in the classes too.
As a result, StringPools never be used anywhere.
Regards,
Chihiro
2020年8月3日(月) 0:40 Chihiro Ito <chiroito107 at gmail.com>:
>
> Hi,
>
> Could you review this fix, please?
>
> This fix passed submit-repo.
>
> JBS : https://bugs.openjdk.java.net/browse/JDK-8250913
> Webrev : http://cr.openjdk.java.net/~cito/JDK-8250913/webrev.00/
>
> Regards,
> Chihiro
More information about the hotspot-jfr-dev
mailing list