RFR(S): 8238375: JFR Test TestJcmdStartFlushInterval is not run

Langer, Christoph christoph.langer at sap.com
Sun Feb 2 15:47:33 UTC 2020


Hi,

when culling errors in my Eclipse IDE, I found an issue with JFR test TestJcmdStartFlushInterval. It can never have been run at all, because it contains the jtreg annotation "@run main/othervm jdk.jfr.jcmd.TestJcmdStartReadOnlyFile" and hence runs a different test.

The wrong run directive shadows an actual compile time error in the test. The method jdk.jfr.Recording::getFlushInterval is package private, so to be able to invoke it in the test that obviously lives in another package, it has to be made accessible via reflection. Here would be the fix. I, however, don't know why getFlushInterval is package private and whether it couldn't/shouldn't be made a public API.

Bug: https://bugs.openjdk.java.net/browse/JDK-8238375
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8238375.0/

Cheers
Christoph



More information about the hotspot-jfr-dev mailing list