RFR(S): 8219999: TestJFREvents container test should not use jdk.CPUInformation event for container CPU values
Erik Gahlin
erik.gahlin at oracle.com
Thu Feb 6 22:50:20 UTC 2020
Looks good.
Erik
On 2020-02-06 22:30, mikhailo.seledtsov at oracle.com wrote:
> Please review this change that updates the TestJFREvents container test.
>
> After more discussions within JFR and Runtime team, we have decided on
> the following:
> - CPUInformation is intended to report hardware-based information,
> and should not be used to report OS or Container related information
> - the active_processor_count information should be reported in a
> Container-specific event (see JDK-8203359 for instance),
> - the test TestJFREvents.java should be modified to not use
> CPUInformation.
>
> I decided not to remove the test case, just to disable it and remove
> usage of jdk.CPUInformation.
> Once Container info events become available, this test case can be
> used/extended for
> testing CPU-related container configuration and info.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8219999
> Webrev: http://cr.openjdk.java.net/~mseledtsov/8219999.00/
> Testing:
> - testing the affected test on container-enabled host
>
>
> Thank you,
> Misha
>
More information about the hotspot-jfr-dev
mailing list