RFR: 8232636: JFR TestDumpOnCrash.java crashed and failed to create emergency

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Wed Jan 22 19:36:11 UTC 2020


Overall looks good.

May I recommend that you parametrize the number of attempts, say using a 
'static final int NUMBER_OF_CRASH_ATTEMPTS' or similar. If you choose to 
do so, no need to send an updated webrev, just make sure to update the

throw new Exception("Three attempts with failure!");


Thanks,
Misha



On 1/22/20, 10:06 AM, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of a test fix that takes into account that crash 
> dump may not always be produced.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8232636
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/8232636/
>
> Testing:
> jdk/jdk/jvm/TestDumpOnCrash.java 100 times
>
> Thanks
> Erik
>


More information about the hotspot-jfr-dev mailing list