RFR: 8223066: jfr metadata" output the @Name annotation twice

[Markus Gronlund]

Hi Erik,

Looks good.

Thanks
Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 16 januari 2020 15:35
To: hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>
Subject: RFR: 8223066: jfr metadata" output the @Name annotation twice

Hi,

Could I have a review of a fix that makes sure @Name annotation is not printed twice.

There are multiple things at hand:

1) What will produced in the file
2) What the consumer API exposes
3) What the 'jfr' tool prints.

This fix will only deal with 3.

Regardless if 1 are fixed later, old recordings can be printed by a newer JDKs so this fix is needed anyway. Doing 1 and 2 is more complicated as there are compatibility aspects and consistency of the API to think about.

Types that lacks a package name will not get the @Name annotation as it is not needed to describe them.

Thanks to Chihiro for finding the issue and doing initial work on this.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8223066

Webrev:
http://cr.openjdk.java.net/~egahlin/8223066/

Testing:
jdk/jdk/jfr

Thanks
Erik