RFR: 8250670: TestJFRIntrinsic.java should be run with and without JFR to check the intrinsic properly
Mario Torre
neugens at redhat.com
Thu Jul 30 12:43:03 UTC 2020
On Thu, Jul 30, 2020 at 2:27 PM Erik Gahlin <erik.gahlin at oracle.com> wrote:
>
> Hi Mario,
Hi Erik,
> There is a test that checks the functionality. See TestGetEventWriter. Maybe it can be improved so it also checks the disabled case as well?
Ok, I'll check this out too.
> We could probably run TestJFRIntrinsic.java with JFR enabled, but not sure we need to run all four cases?
I'm not sure what would be the purpose of this test however. I thought
that running the test with and without JFR would give us an indication
if the intrinsic works, but I think we still want to test both "all
compiled" and fully tiered?
Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the hotspot-jfr-dev
mailing list