RFR (M) 8235573: Move JFR ObjectSample oop into OopStorage

[Markus Gronlund]

Hi Coleen,

Looks good.

Thank you for the work done and also for incorporating my modifications.

I have one open question about the naming of the OopStorage instance:

OopStorageSet::create_weak("JFR Old Object Samples"); 

I named it like this because it describes what it represents from a JFR perspective. I have also seen other OopStorage names that encode the term "Weak" into the actual name, so I am trying to understand how this will be used. My guess is that it is to distinguish between the different oop storages and their types as part of logging (GC logging?). If the logging expects or prefers the oop storage type to be encoded into the name, then maybe it should instead be called "Weak JFR Old Object Samples"?

Thanks
Markus


-----Original Message-----
From: Coleen Phillimore 
Sent: den 31 juli 2020 17:43
To: hotspot-dev developers <hotspot-dev at openjdk.java.net>; hotspot-jfr-dev at openjdk.java.net
Subject: Re: RFR (M) 8235573: Move JFR ObjectSample oop into OopStorage


Markus contributed a better incremental patch on top of this, please review tested 02 patch instead.

open webrev at http://cr.openjdk.java.net/~coleenp/2020/8235573.02/webrev

Thanks,
Coleen

On 7/31/20 10:16 AM, coleen.phillimore at oracle.com wrote:
> Summary: Add a weak OopStorage for JFR and move the oops there. Remove 
> GC code to process oops.
>
> Tested with tier1,5, and 6.  Built with shenandoah.
>
> open webrev at 
> http://cr.openjdk.java.net/~coleenp/2020/8235573.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8235573
>
> Thanks,
> Coleen