RFR [XS]: 8241064: JFR related tests TestMetaspaceAllocationFailure.java and TestEventInstrumentation.java miss requires tag

Baesken, Matthias matthias.baesken at sap.com
Tue Mar 17 11:18:33 UTC 2020


Thanks for the review!

In case of no objections, I'll push it as trivial .

Best regards, Matthias

-----Original Message-----
From: Markus Gronlund <markus.gronlund at oracle.com> 
Sent: Dienstag, 17. März 2020 11:59
To: Baesken, Matthias <matthias.baesken at sap.com>; hotspot-dev at openjdk.java.net; hotspot-jfr-dev at openjdk.java.net
Subject: RE: RFR [XS]: 8241064: JFR related tests TestMetaspaceAllocationFailure.java and TestEventInstrumentation.java miss requires tag

Hi Matthias,

Looks good and trivial.

Thank you for fixing this.
Markus

-----Original Message-----
From: Baesken, Matthias <matthias.baesken at sap.com> 
Sent: den 17 mars 2020 08:29
To: hotspot-dev at openjdk.java.net; hotspot-jfr-dev at openjdk.java.net
Subject: RFR [XS]: 8241064: JFR related tests TestMetaspaceAllocationFailure.java and TestEventInstrumentation.java miss requires tag

Hello, please review this very small fix .
The JFR related tests
jdk/jfr/event/runtime/TestMetaspaceAllocationFailure.java
and
jdk/jfr/javaagent/TestEventInstrumentation.java

miss the vm.hasJFR tag, this leads to failures on platforms without JFR.

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8241064

http://cr.openjdk.java.net/~mbaesken/webrevs/8241064.0/

Thanks, Matthias


More information about the hotspot-jfr-dev mailing list