RFR: 8241828: JFR: Some streaming tests require a larger heap size with ZGC

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Mon Mar 30 17:24:10 UTC 2020


Hi Stefan,

I would recommend adding "@requires os.maxMemory > " to the test, to 
make sure that test does not execute on a host/node that does not have 
sufficient memory. E.g. "@requires os.maxMemory > 1G"

Otherwise the change looks good to me.


Thanks,

Misha

On 3/30/20 4:07 AM, Stefan Karlsson wrote:
> Hi all,
>
> Please review this small patch to increase the max heap size of a 
> couple of JFR streaming tests.
>
> https://cr.openjdk.java.net/~stefank/8241828/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8241828
>
> The default heap size is 512m when these tests are run. G1 uses almost 
> 500m, but ZGC needs a bit more. I propose that we set the max heap 
> size to 768m.
>
> Thanks,
> StefanK


More information about the hotspot-jfr-dev mailing list