Re: RFR: 8238665: Add JFR event for direct memory statistics

[Denghui Dong]

thanks for the review!

updated, still in http://cr.openjdk.java.net/~ddong/8238665/webrev.04/

could you sponsor it if everything is okay?

Thanks,
Denghui



------------------------------------------------------------------
From:Alan Bateman <Alan.Bateman at oracle.com>
Send Time:2020年3月31日(星期二) 17:22
To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>; Erik Gahlin <erik.gahlin at oracle.com>
Cc:hotspot-jfr-dev <hotspot-jfr-dev at openjdk.java.net>; core-libs-dev <core-libs-dev at openjdk.java.net>
Subject:Re: RFR: 8238665: Add JFR event for direct memory statistics

On 19/03/2020 08:35, Denghui Dong wrote:
>
> Make sense, updated.
>
> Webrev: http://cr.openjdk.java.net/~ddong/8238665/webrev.04/
>
Thanks for the updates, looks much better.

A minor comment on ManagementFactoryHelper is that bufferPools doesn't 
have to initialized to null. That will avoid a volatile write.

-Alan.