JFR: Clean up jdk.jfr.internal.RepositoryChunk
Erik Gahlin
erik.gahlin at oracle.com
Wed May 6 08:08:19 UTC 2020
Good suggestion. I will fix that.
Thanks!
Erik
> On 6 May 2020, at 09:53, Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com> wrote:
>
> Hi Erik,
>
> The change looks good.
> Only one nit you can feel free to ignore - perhaps `Utils.format()`
> could be renamed to `Utild.formatDateTime()` to better signal the
> purpose (http://cr.openjdk.java.net/~egahlin/8244463/src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java.sdiff.html
> L185)?
>
> Cheers,
>
> -JB-
>
> On Tue, May 5, 2020 at 8:35 PM Erik Gahlin <erik.gahlin at oracle.com> wrote:
>>
>> Hi,
>>
>> Could I have a review of a fix that cleans up the RepositoryChunk class.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8244463
>>
>> Webrev:
>> http://cr.openjdk.java.net/~egahlin/8244463/
>>
>> Testing: jdk/jdk/jfr
>>
>> Thanks
>> Erik
More information about the hotspot-jfr-dev
mailing list