RFR: 8246130 JFR: TestInheritedAnnotations has incorrect validation

Markus Gronlund markus.gronlund at oracle.com
Fri May 29 09:19:49 UTC 2020


Looks good.

Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 29 maj 2020 10:52
To: j >> hotspot-jfr-dev at openjdk.java.net <hotspot-jfr-dev at openjdk.java.net>
Subject: RFR: 8246130 JFR: TestInheritedAnnotations has incorrect validation

Hi,

Could I have a review of a test fix. 

Among other things, the test tries to check that settings are inherited between event classes, but the logic is incorrect so that part of the test can never fail.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8246130 <https://bugs.openjdk.java.net/browse/JDK-8246130>

Webrev:
http://cr.openjdk.java.net/~egahlin/8246130 <http://cr.openjdk.java.net/~egahlin/8246130>

Testing: jdk/jdk/jfr

Thanks
Erik


More information about the hotspot-jfr-dev mailing list