RFR: 8253694: Remove Thread::muxAcquire() from ThreadCrashProtection() [v3]

[Coleen Phillimore]

On Mon, 28 Sep 2020 21:04:39 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.hpp line 756:
>> 
>>> 754:   }
>>> 755: #endif
>>> 756:
>> 
>> Could this be pushed down into osThread ?
>
> Yes, it can but it's not that clean I think given the osthread indirections. Here's how it looks:
> https://github.com/pchilano/jdk/commit/73a41ad867b4b7466cdddc87173828b4e80f8179
> I think another alternative could be to remove the "#ifndef _WINDOWS" clause and define an empty
> check_crash_protection() method in os_windows.hpp

Ok, yes, I saw the ifdef WINDOWS and thought it should be more os platform specific, but if you had an empty method in
os_windows.hpp that would be better imo.  It's not as nice in osthread.  Thank you for considering it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/376