Integrated: 8253694: Remove Thread::muxAcquire() from ThreadCrashProtection()
Patricio Chilano Mateo
pchilanomate at openjdk.java.net
Tue Oct 6 14:52:08 UTC 2020
On Mon, 28 Sep 2020 06:07:58 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
> Hi all,
>
> Please review the following patch. Current ThreadCrashProtection() implementation uses static members which requires
> the use of Thread::muxAcquire() to allow only one user at a time. We can avoid this synchronization requirement if each
> thread has its own ThreadCrashProtection *data. I tested it builds on Linux, macOS and Windows. Since the
> JfrThreadSampler is the only one using this I run all the tests from test/jdk/jdk/jfr/. I also run some tests with JFR
> enabled while forcing a crash in OSThreadSampler::protected_task() and tests passed with several "Thread method sampler
> crashed" UL output. Also run tiers1-3. Thanks, Patricio
This pull request has now been integrated.
Changeset: 57493c19
Author: Patricio Chilano Mateo <pchilanomate at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/57493c19
Stats: 26 lines in 6 files changed: 6 ins; 18 del; 2 mod
8253694: Remove Thread::muxAcquire() from ThreadCrashProtection()
Reviewed-by: dholmes, dcubed, coleenp
-------------
PR: https://git.openjdk.java.net/jdk/pull/376
More information about the hotspot-jfr-dev
mailing list