RFR: 8245194: Unix domain socket channel implementation [v17]

Michael McMahon michaelm at openjdk.java.net
Fri Oct 9 14:39:14 UTC 2020


On Fri, 9 Oct 2020 09:14:33 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unixdomainchannels:
>>   - updated property name
>>   - added JFR unit test
>
> test/jdk/java/nio/channels/unixdomain/IOExchanges.java line 113:
> 
>> 111:         SPINBAccep_NBConn_NBIO_WR_11a
>> 112:         SPINBAccep_NBConn_NBIO_RW_12a
>> 113:     */
> 
> I recognise this test ;-)  I thought there was a version for IP-specific channels, but cannot find it now. I was going
> to ask if these could be merged or abstracted out somehow.

Chris,
Thanks for the comments. I will incorporate them all into the next revision. As regards the IOExchanges test, it uses a
@DataProvider of ProtocolFamily with values "UNIX" and "INET" which means the tests are run for TCP sockets. Is that
what you were asking? I'm not sure I get the question exactly. Michael.

-------------

PR: https://git.openjdk.java.net/jdk/pull/52


More information about the hotspot-jfr-dev mailing list