PING: 8253235: JFR.dump does not respect maxage parameter

[Ekaterina Vergizova]

PING: Could anyone please review this small fix?

Thanks,
Ekaterina


-----Original Message-----
From: hotspot-jfr-dev <hotspot-jfr-dev-retn at openjdk.java.net> On Behalf Of Ekaterina Vergizova
Sent: Friday, September 18, 2020 1:23 PM
To: hotspot-jfr-dev at openjdk.java.net
Subject: RFR: 8253235: JFR.dump does not respect maxage parameter

JFR.dump command creates a clone of the original recording, but maxage and maxsize parameters are not copied to the clone in PlatformRecording.newSnapshotClone(). When PlatformRecording.appendChunk() is called for the clone to append the latest data, trimToAge() and trimToSize() are not performed because maxAge and maxSize are not set. Therefore the clone sometimes dumps outdated chunks to the disk.

Testing:
jdk/jdk/jfr/*

-------------

Commit messages:
 - 8253235: JFR.dump does not respect maxage parameter

Changes: https://git.openjdk.java.net/jdk/pull/239/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=239&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253235
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/239.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/239/head:pull/239

PR: https://git.openjdk.java.net/jdk/pull/239