RFR: JDK-8253641: Missing newline in PrettyWriter::printClassLoader if classloader is null.

Michael Bien github.com+114367+mbien at openjdk.java.net
Tue Oct 20 13:52:22 UTC 2020


On Tue, 20 Oct 2020 12:11:11 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Hi Michael, I think you can go ahead and merge the blocks.
>> 
>> Thanks
>> Markus
>
> You will also need to align the name of this PR with the synopsis of the JIRA issue, the bots complain about:
> 
> Integration blocker
> 
>  ⚠️ Title mismatch between PR and JBS for issue JDK-8253641

@mgronlun Thank you for the review, I made some changes:

 - changed the original fix so that the postFix is printed in every case after comparing it with similar methods (please
   review again)
 - added commit which merges the two consecutive ifs over same variable
 - added JDK- prefix to this issue but the bot hasn't noticed yet

-------------

PR: https://git.openjdk.java.net/jdk/pull/248


More information about the hotspot-jfr-dev mailing list