RFR: 8245194: Unix domain socket channel implementation [v31]

[Michael McMahon]

On Tue, 20 Oct 2020 13:59:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   forgot to stage updated test files in last commit
>
> test/jdk/java/net/UnixDomainSocketAddress/AddressTest.java line 45:
> 
>> 43:  * if given a Path that does not originate from system default
>> 44:  * file system.
>> 45:  */
> 
> I was thinking to put that in a `@summary` just after `@test` above ...

I was going to put it there, but I think it's too much text for an @summary imo

> test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java line 85:
> 
>> 83:                 launch(className, null, null, Util.getFD(sc2));
>> 84:             }
>> 85:             Files.delete(addr.getPath());
> 
> should that be:
> try (...) {
> } finally {
>     Files.deleteIfExists(addr.getPath);
> }

You're right. Thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/52