RFR: 8245194: Unix domain socket channel implementation [v35]

Michael McMahon michaelm at openjdk.java.net
Wed Oct 28 11:53:54 UTC 2020


On Sat, 24 Oct 2020 08:12:57 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   - fixed 32 bit Linux build error
>>   - test updates from Chris
>
> src/java.base/windows/classes/sun/nio/ch/WindowsSelectorImpl.java line 148:
> 
>> 146:         // Disable the Nagle algorithm so that the wakeup is more immediate
>> 147:         SinkChannelImpl sink = (SinkChannelImpl)wakeupPipe.sink();
>> 148:         wakeupSinkFd = ((SelChImpl)sink).getFDVal();
> 
> The "Disable the ..." comment can be removed as it's handled in PipeImpl now. "sink" can be removed so that wakeupSourceFd and wakeupSinkFd can be created the same way.

Thanks, I pushed that change yesterday.

-------------

PR: https://git.openjdk.java.net/jdk/pull/52


More information about the hotspot-jfr-dev mailing list