RFR: 8240556: Abort concurrent mark after effective eager reclamation of humongous objects [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Sep 23 14:50:08 UTC 2020


On Tue, 22 Sep 2020 08:14:07 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase.
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 707:
> 
>> 705:     root_regions()->cancel_scan();
>> 706:     return;
>> 707:   }
> 
> I still think this should be broken out from this function. Either doing it in
> `G1ConcurrentMarkThread::concurrent_undo_cycle_do()` or having a separate function that is called right before
> `_cm_thread->start_undo_mark()` in `CollectedHeap::start_concurrent_cycle()`.

Done in the latest change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/177


More information about the hotspot-jfr-dev mailing list