RFR: 8203359: Container level resources events [v8]

[Jaroslav Bachorik]

On Wed, 14 Apr 2021 10:26:44 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Roll back conditional registration of container events
>>  - Remove container events flag
>>  - Remove trailing spaces
>>  - Doh
>>  - Report container type and register events conditionally
>>  - Remove unused test files
>>  - Initial test support for JFR container events
>>  - Update the JFR control files
>>  - Split off the CPU throttling metrics
>>  - Formatting spaces
>>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/e80012ed...67a61bd7
>
> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerCPUThrottlingEvent.java line 46:
> 
>> 44: public class ContainerCPUThrottlingEvent extends AbstractJDKEvent {
>> 45:   @Label("CPU Elapsed Slices")
>> 46:   @Description("Number of time-slice periods that have elapsed if a CPU quota has been setup for the container.")
> 
> If the description is one sentence, period should not be included.

Fixed in all locations

> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerCPUUsageEvent.java line 46:
> 
>> 44: public class ContainerCPUUsageEvent extends AbstractJDKEvent {
>> 45:   @Label("CPU Time")
>> 46:   @Description("Aggregate time, in nanoseconds, consumed by all tasks in the container.")
> 
> We usually skip the unit "nanoseconds" in descriptions when the field has a content type that describes the unit.

Gone

> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerConfigurationEvent.java line 45:
> 
>> 43: @Description("A set of container specific attributes.")
>> 44: public final class ContainerConfigurationEvent extends AbstractJDKEvent {
>> 45:     @Label("Container type")
> 
> Capitalize "type" in the label

Done

> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerConfigurationEvent.java line 78:
> 
>> 76: 
>> 77:     @Label("Memory and Swap Limit")
>> 78:     @Description("Maximum amount of physical memory and swap space, in bytes, that can be allocated in the container.")
> 
> No need to mention bytes in the description when the field has DataAmount annotation.

Yep. Done.

> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerIOUsageEvent.java line 47:
> 
>> 45: public class ContainerIOUsageEvent extends AbstractJDKEvent {
>> 46: 
>> 47:   @Label("BlkIO Request Count")
> 
> Change to "Block IO"

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/3126