RFR: 8266206: Build failure after JDK-8264752 with older GCCs

Aleksey Shipilev shade at openjdk.java.net
Wed Apr 28 15:45:54 UTC 2021


On Wed, 28 Apr 2021 11:23:30 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug report for error log. It seems older GCCs dislike `const char*` as template argument without it being the `constexpr`. Since the bug is marked for eventual backports to 8u and 11u, I think we better play it safe and drop the template argument to `bool`, and select the message in the method body.
> 
> Additional testing:
>  - [x] build passes with GCC 6.3.0
>  - [x] build passes with GCC 9.3.0
>  - [x] `jdk_jfr` passes

Thanks! Any other reviews? Is it trivial? 
I would like to have clean nightlies tonight.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3759


More information about the hotspot-jfr-dev mailing list