RFR: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling

[Lutz Schmidt]

On Tue, 17 Aug 2021 07:35:54 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp line 97:
>> 
>>> 95:       //  - ijava_state_unchecked() calculates it's result as
>>> 96:       //      istate = fp() - z_ijava_state_size() = NULL - 0x68 DEBUG_ONLY(-8)
>>> 97:       //  - istate->method dereferences memory at offset 8 from istate
>> 
>> I think a reference to the JBS issue would suffice as a comment here.
>
> Years ago, I was told that direct references to JBS bugs in the code are strongly discouraged. On the other hand, I regard it as very important to have a detailed description available. So what to do? I need a second review anyway. Maybe she has a third opinion on that.

By the way: Thanks a lot for the review!!!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5071