[jdk16] Integrated: 8257215: JFR: Events dropped when streaming over a chunk rotation

Erik Gahlin egahlin at openjdk.java.net
Mon Feb 1 06:00:44 UTC 2021


On Mon, 25 Jan 2021 19:06:12 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi, 
> 
> Could I have review of an intermittent product issue. It happens about 1 out of 300 the test is run.
> 
> By design, chunk files that have been parsed are deleted. Problem is that the filename could be reused, which causes issues. This happens on the server, where the files are read before they are transfered over the network, and on the client when chunks are read from the local repository. 
> 
> The logic for creating the chunk file names is now in a separate class (ChunkFilename) so it can be shared by server and client. Another problem was the clock source being used when purging files. It was not always the same as when timestamp was taken from the chunk.
> 
> Testing: Ran TestRotate.java 2100 times without failure
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: 21f8bf44
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.java.net/jdk16/commit/21f8bf44
Stats:     223 lines in 14 files changed: 138 ins; 56 del; 29 mod

8257215: JFR: Events dropped when streaming over a chunk rotation

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.java.net/jdk16/pull/131


More information about the hotspot-jfr-dev mailing list