Integrated: JDK-8261593: Do not use NULL pointer as write buffer parameter in jfrEmergencyDump.cpp write_repository_files

[Matthias Baesken]

On Thu, 11 Feb 2021 14:24:01 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In jfrEmergencyDump.cpp write_repository_files, potentially (when malloc fails) a NULL pointer is passed as second (buffer) parameter to os::write .
> This is unwanted, see also the Sonar finding :
> 
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=cpp&open=AXck7_SvBBG2CXpcnJEx&resolved=false&severities=CRITICAL&types=BUG
> 
> bytes_written += (int64_t)os::write(emergency_fd, copy_block, bytes_read - bytes_written);
> 
> Sonar reports here : "Null pointer passed as read buffer "copy_block" in call to "write""

This pull request has now been integrated.

Changeset: 92ff8918
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/92ff8918
Stats:     5 lines in 1 file changed: 3 ins; 2 del; 0 mod

8261593: Do not use NULL pointer as write buffer parameter in jfrEmergencyDump.cpp write_repository_files

Reviewed-by: stuefe, mgronlun

-------------

PR: https://git.openjdk.java.net/jdk/pull/2525