RFR: JDK-8261873: Do not start a deleted thread in jfrRecorderThread.cpp start_thread

Wed Feb 17 10:12:41 UTC 2021

On Wed, 17 Feb 2021 08:26:02 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In jfrRecorderThread.cpp start_thread there is a code path where potentially
> Thread::start is called on a deleted thread, this should be avoided.
> 
> See also the related Sonar finding :
> 
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=cpp&open=AXck7_QbBBG2CXpcnIyR&resolved=false&severities=BLOCKER&types=BUG

A false positive because TRAPS and CHECK_NULL macros are used to unwind if there is a problem. I understand such a pattern will be very hard to detect for these kinds of tools, and would assume there is a lot of these in the Hotspot source code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2603