RFR: 8262329: Fix JFR parser exception messages [v2]

Erik Gahlin egahlin at openjdk.java.net
Thu Feb 25 15:10:45 UTC 2021


On Thu, 25 Feb 2021 11:04:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> I've been irritated by unreasonable large constant pool offsets in ChunkParser excepion messages. It turns out that lastCP + size concatenates the two numbers as strings instead of adding them.
>> 
>> Testing:
>>  - [x] manually inspecting the exception messages
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correctly compare strings

I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.

-------------

Marked as reviewed by egahlin (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2714


More information about the hotspot-jfr-dev mailing list